# HG changeset patch # User blanchet # Date 1337874395 -7200 # Node ID 7a642e5c272c501aec8188d3ec640be55fdeafd7 # Parent 1e790c27162ded625e5fd30fc5e442246dd3f412 fixed soundness bug in Nitpick related to unfolding -- the unfolding criterion must at least as strict when looking at a definitional axiom as elsewhere, otherwise we end up unfolding a constant's definition in its own definition, yielding a trivial equality diff -r 1e790c27162d -r 7a642e5c272c src/HOL/Tools/Nitpick/nitpick_hol.ML --- a/src/HOL/Tools/Nitpick/nitpick_hol.ML Thu May 24 17:42:47 2012 +0200 +++ b/src/HOL/Tools/Nitpick/nitpick_hol.ML Thu May 24 17:46:35 2012 +0200 @@ -1733,7 +1733,7 @@ | NONE => let fun def_inline_threshold () = - if is_boolean_type (nth_range_type (length ts) T) andalso + if is_boolean_type (body_type T) andalso total_consts <> SOME true then def_inline_threshold_for_booleans else