# HG changeset patch
# User krauss
# Date 1306090753 -7200
# Node ID fcb6250bf6b454a45b0b28bca9cb0386f08cbc75
# Parent  ddff373cf3adf935a73a9bfa8a4aba782e917fc6
fun command produces warning when patterns are incomplete (somewhat analogous to primrec)

diff -r ddff373cf3ad -r fcb6250bf6b4 src/HOL/Tools/Function/fun.ML
--- a/src/HOL/Tools/Function/fun.ML	Sun May 22 14:51:42 2011 +0200
+++ b/src/HOL/Tools/Function/fun.ML	Sun May 22 20:59:13 2011 +0200
@@ -83,15 +83,25 @@
     spec @ mk_catchall fixes arity_of
   end
 
-fun warn_if_redundant ctxt origs tss =
+fun warnings ctxt origs tss =
   let
-    fun msg t = "Ignoring redundant equation: " ^ quote (Syntax.string_of_term ctxt t)
+    fun warn_redundant t =
+      Output.warning ("Ignoring redundant equation: " ^ quote (Syntax.string_of_term ctxt t))
+    fun warn_missing strs =
+      Output.warning (cat_lines ("Missing patterns in function definition:" :: strs))
+
+    val (tss', added) = chop (length origs) tss
 
-    val (tss', _) = chop (length origs) tss
-    fun check (t, []) = (warning (msg t); [])
-      | check (t, s) = s
+    val _ = case chop 3 (flat added) of
+       ([], []) => ()
+     | (eqs, []) => warn_missing (map (Syntax.string_of_term ctxt) eqs)
+     | (eqs, rest) => warn_missing (map (Syntax.string_of_term ctxt) eqs
+         @ ["(" ^ string_of_int (length rest) ^ " more)"])
+
+    val _ = (origs ~~ tss')
+      |> map (fn (t, ts) => if null ts then warn_redundant t else ())
   in
-    (map check (origs ~~ tss'); tss)
+    ()
   end
 
 fun sequential_preproc (config as FunctionConfig {sequential, ...}) ctxt fixes spec =
@@ -107,8 +117,8 @@
 
       val compleqs = add_catchall ctxt fixes feqs (* Completion *)
 
-      val spliteqs = warn_if_redundant ctxt feqs
-        (Function_Split.split_all_equations ctxt compleqs)
+      val spliteqs = Function_Split.split_all_equations ctxt compleqs
+        |> tap (warnings ctxt feqs)
 
       fun restore_spec thms =
         bnds ~~ take (length bnds) (unflat spliteqs thms)