more robust build, with proper rebuild of node-pty;
authorwenzelm
Fri, 12 Sep 2025 18:38:23 +0200
changeset 83140 9c7446adfbc6
parent 83139 c87375585b9f
child 83141 11d4e7098a38
more robust build, with proper rebuild of node-pty;
src/Tools/VSCode/src/component_vscodium.scala
--- a/src/Tools/VSCode/src/component_vscodium.scala	Fri Sep 12 17:31:38 2025 +0200
+++ b/src/Tools/VSCode/src/component_vscodium.scala	Fri Sep 12 18:38:23 2025 +0200
@@ -69,9 +69,7 @@
       "VSCODE_LATEST=no",
       "CI_BUILD=no",
       "SKIP_ASSETS=yes",
-      "SHOULD_BUILD=yes",
-      "SHOULD_BUILD_REH=no",
-      "SHOULD_BUILD_REH_WEB=no")
+      "SHOULD_BUILD=yes")
 
   def build_upstream_env(dir: Path): List[String] = {
     val str = File.read(dir + Path.explode("upstream/stable.json"))
@@ -480,7 +478,7 @@
 
 * x86_64-windows with Cygwin-Terminal, using prerequisites in typical locations:
 
-    isabelle component_vscodium -M "/cygdrive/c/msys64" -n "/cygdrive/c/Program Files/nodejs" -P /cygdrive/c/Python313/python.exe
+    isabelle component_vscodium -M "/cygdrive/c/msys64" -P /cygdrive/c/Python313/python.exe
 
 
         Makarius
@@ -528,13 +526,6 @@
   Windows prerequisites:
     - install Visual Studio 2022 with C++ development and C++ library with
       Spectre mitigation: see https://visualstudio.microsoft.com/downloads
-    - install Nodejs """ + default_node_version + """ including Windows build tools:
-      see https://nodejs.org/dist/v""" + default_node_version +
-        "/node-v" + default_node_version + """-x64.msi
-    - rebuild native node-pty, using "cmd" as Administrator:
-        npm install --global node-gyp node-pty@1.1.0-beta33
-        cd "C:\Program Files\nodejs\node_modules\node-pty"
-        npx node-gyp rebuild node-pty
     - MSYS2/UCRT64: see https://www.msys2.org
     - MSYS2 packages:
       pacman -Su