discontinue special treatment of bundled node_modules (in contrast to 33fb3014876f): build now works on actual platform, and is supposed to produced proper results;
authorwenzelm
Sat, 06 Sep 2025 22:20:02 +0200
changeset 83106 e0ebbdd1ad36
parent 83105 372e27932389
child 83107 917ad72422a6
discontinue special treatment of bundled node_modules (in contrast to 33fb3014876f): build now works on actual platform, and is supposed to produced proper results;
src/Tools/VSCode/src/component_vscodium.scala
--- a/src/Tools/VSCode/src/component_vscodium.scala	Fri Sep 05 21:55:19 2025 +0200
+++ b/src/Tools/VSCode/src/component_vscodium.scala	Sat Sep 06 22:20:02 2025 +0200
@@ -265,27 +265,6 @@
       patch
     }
 
-    def init_resources(base_dir: Path): Path = {
-      val dir = base_dir + resources
-      if (platform.is_macos) {
-        Isabelle_System.symlink(Path.explode("VSCodium.app/Contents/Resources"), dir)
-      }
-      dir
-    }
-
-    def setup_node(target_dir: Path, progress: Progress): Unit = {
-      Isabelle_System.with_tmp_dir("download") { download_dir =>
-        download(download_dir, progress = progress)
-        val dir1 = init_resources(download_dir)
-        val dir2 = init_resources(target_dir)
-        for (name <- Seq("app/node_modules", "app/node_modules.asar")) {
-          val path = Path.explode(name)
-          Isabelle_System.rm_tree(dir2 + path)
-          Isabelle_System.copy_dir(dir1 + path, dir2 + path)
-        }
-      }
-    }
-
     def setup_electron(dir: Path): Unit = {
       val electron = Path.explode("electron")
       if (platform.is_linux) {
@@ -410,7 +389,10 @@
 
       val platform_dir = build_context.platform_dir(component_dir.path)
       Isabelle_System.copy_dir(build_context.build_dir(build_dir), platform_dir)
-      build_context.setup_node(platform_dir, progress)
+      if (platform.is_macos) {
+        Isabelle_System.symlink(Path.explode("VSCodium.app/Contents/Resources"),
+          platform_dir + resources)
+      }
       build_context.setup_electron(platform_dir)
 
       val resources_patch = build_context.patch_resources(platform_dir)